Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove outstanding testing-library/react-hooks usages #205307

Merged
merged 5 commits into from
Jan 7, 2025
Merged

remove outstanding testing-library/react-hooks usages #205307

merged 5 commits into from
Jan 7, 2025
+73 −80

Conversation

eokoneyo
Copy link
Contributor

@eokoneyo eokoneyo commented Dec 31, 2024 •
edited by kibanamachine
Loading

Summary

This PR removes usages of @testing-library/react-hooks from the codebase, as we've transitioned to using @testing-library/react especially that it provides the same utils we need and the later package is not supported for react 18. alongside this other instance of the usages for @testing-library/react-hooks have been removed an eslint rule has been enabled to prevent further usages of the mentioned package.

@eokoneyo eokoneyo requested review from a team as code owners December 31, 2024 10:10
@botelastic botelastic bot added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Dec 31, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@eokoneyo eokoneyo added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Dec 31, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@eokoneyo eokoneyo added the release_note:skip Skip the PR/issue when compiling release notes label Dec 31, 2024
KDKHD
KDKHD approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@KDKHD KDKHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Generative AI files look good.

@botelastic botelastic bot added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Dec 31, 2024
@eokoneyo eokoneyo added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Dec 31, 2024
@botelastic botelastic bot added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Dec 31, 2024
Dosant
Dosant approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@eokoneyo eokoneyo force-pushed the chore/remove-testing-library-react-hooks branch from de2bfa5 to 84af98d Compare December 31, 2024 14:40
@eokoneyo eokoneyo requested a review from a team as a code owner December 31, 2024 14:40
@eokoneyo eokoneyo changed the title remove testing-library/react-hooks remove outstanding testing-library/react-hooks usages Dec 31, 2024
awahab07
awahab07 approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obs-ux-logs changes LGTM!

@eokoneyo eokoneyo force-pushed the chore/remove-testing-library-react-hooks branch 2 times, most recently from be7b975 to 6f102b9 Compare January 2, 2025 09:21
jbudz
jbudz approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.eslintrc.js LGTM

@Dosant Dosant mentioned this pull request Jan 2, 2025
Open
@eokoneyo eokoneyo force-pushed the chore/remove-testing-library-react-hooks branch from 6f102b9 to 72636c8 Compare January 6, 2025 09:14
@eokoneyo
Copy link
Contributor Author

eokoneyo commented Jan 6, 2025

@elasticmachine merge upstream

machadoum
machadoum approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EA changes LGTM ✅

@eokoneyo eokoneyo removed the request for review from abhishekbhatia1710 January 7, 2025 10:26
@eokoneyo
Copy link
Contributor Author

eokoneyo commented Jan 7, 2025

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@eokoneyo eokoneyo merged commit 1c3f7a6 into elastic:main Jan 7, 2025
8 checks passed
@eokoneyo eokoneyo deleted the chore/remove-testing-library-react-hooks branch January 7, 2025 13:43
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12652765850

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 205307

Questions ?

Please refer to the Backport tool documentation

@eokoneyo eokoneyo self-assigned this Jan 7, 2025
@eokoneyo eokoneyo mentioned this pull request Jan 7, 2025
Open
@eokoneyo
Copy link
Contributor Author

eokoneyo commented Jan 7, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfirpeled kfirpeled kfirpeled approved these changes

@KDKHD KDKHD KDKHD approved these changes

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

@Dosant Dosant Dosant approved these changes

@mbondyra mbondyra mbondyra approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@jbudz jbudz jbudz approved these changes

@Bluefinger Bluefinger Bluefinger approved these changes

@awahab07 awahab07 awahab07 approved these changes

@adcoelho adcoelho adcoelho approved these changes

@machadoum machadoum machadoum approved these changes

Assignees

@eokoneyo eokoneyo

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) React@18 release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.